Hani,
I am vehemently opposed to build.bat and build.sh. All you need is ant. I'm likewise against checking in ant to every single project. It's a fairly reasonable assumption that people who might need to build a project have ant installed (you don't bundle gnu make with every project that has a Makefile).I have to go with Pat here - having Ant in each project makes it much easier for people to get going. Believe it or not, there are a ton of developers out there who are too lazy to install and keep Ant up to date. Besides, do you really want to deal with people emailing the list asking for build help that will come from 1) not having the correct version of Ant installed on their system or 2) not having ant installed at all? :)
Likewise, I'm against forcing a particular coding style. the coverage reports and suchlike are just eye candy really, so I'm ambivalent there.I think adhering to the standard Java coding conventions would be a good idea. I love WebWork and think it's great but I found the code incredibly hard to read and understand, mostly because it's not formatted well and the comments are thin. (BTW, the SiteMesh code is the exact opposite - much nicer.) IMHO, clean, standard formatted code goes a long way, especially in an open-source project.
Regards,
--Bill
On Tuesday, December 17, 2002, at 11:11 AM, Patrick Lightbody wrote:I think we should standardize the OpenSymphony build process. Here is my
first cut at it, please comment:
- attached is a build script for OSCore, but as you can see, it's very
generic. We should use this as a base and not add much more to it, mostly
instructions on how to package files like ejb-jar.xml in to the jar itself.
-the directory structure of CVS would look like:
project/
project/docs
project/lib
project/lib/build
project/lib/build/jalopy
project/lib/core
project/lib/optional
project/src/etc
project/src/java
project/src/test
project/src/example [if needed]
There would be build.bat and build.sh scripts to build the project, meaning
CVS is self-contained (no ant install needed). So that means that ant and
all the optional tasks would be in lib/build.
- distribution structure:
project.zip/
project.zip/project.jar
project.zip/docs/
project.zip/docs/api
project.zip/docs/clover
project.zip/docs/junit
project.zip/docs/lib
project.zip/docs/src
- if you see in the script, there would be three extra tasks built in to the
build script:
* jalopy (code formatting)
* junit (unit tests)
* clover (test coverage reports)
- Documentation is assumed to be HTML right now, but pending Ken's final
thoughts, this would change. Also, the junit and clover reports could be run
through XSLs as well.
<build.xml>
-------------------------------------------------------
This sf.net email is sponsored by:
With Great Power, Comes Great Responsibility Learn to use your power at OSDN's High Performance Computing Channel
http://hpc.devchannel.org/
_______________________________________________
Opensymphony-webwork mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
