On 10/25/07, Tomaso Tosolini <[EMAIL PROTECTED]> wrote:
> Ok,
> here is the archive
>
> I would be grateful you could let me know about any addition and/or
> change needed
Hi Tomaso,
you've done lots of work, congratulations.
Some points :
- could you tell your text editor to treat tabs as 4 whitespaces ?
Indentation is very random on my side, tabs are bad
- why naming the database table engine_db_storage, why not naming it
"expressions" (and "errors" or "process_errors") ? It follows the
ActiveRecord style where a table of customers is named "customers"
- serialization to YAML is automatic, no need to call dump or load by
yourself, in the ActiveRecord base extension, for example :
class Thing < ActiveRecord::Base
belongs_to :workitem
serialize :my_column
end
http://api.rubyonrails.org/classes/ActiveRecord/Base.html#M001020
Wdyt ?
Best regards, thanks,
--
John Mettraux -///- http://jmettraux.openwfe.org
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"OpenWFEru dev" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/openwferu-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
