On Wed, Apr 17, 2019 at 12:21 PM Ilya Maximets <i.maxim...@samsung.com> wrote:
> On 17.04.2019 11:37, David Marchand wrote: > > On Tue, Apr 16, 2019 at 4:01 PM Ilya Maximets <i.maxim...@samsung.com > <mailto:i.maxim...@samsung.com>> wrote: > > > + LIST_FOR_EACH (dev, list_node, &dpdk_list) { > > > + ovs_mutex_lock(&dev->mutex); > > > + if (nullable_string_is_equal(ifname, dev->vhost_id)) { > > > + uint32_t qp_num = NR_QUEUE; > > > + > > > > It might be good to check if device is destroyed here and log an > error > > otherwise. > > > > > > So that we have a log similar to what we have in destroy_device() ? > > Not sure if I understand the question correctly. I meant something like: > > if (netdev_dpdk_get_vid(dev) >= 0) { > VLOG_ERR(Connection on socket '%s' destroyed while vhost device still > attached.", > dev->vhost_id); > } > > But it's probably a good idea to log an error if we didn't find any > matching > device in 'dpdk_list' too. > Ok, I had the latter in mind, thanks for clarifying the check on netdev_dpdk_get_vid. Will add both. -- David Marchand _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
