It's not easy to add a fail test without the changed code. But I test it failed with the old code manually following these steps, 1. Apply this patch(with test in it) 2. Revert the changed code in netdev-offload-tc.c 3. Run the test
Yes, the fail-test above sometimes may pass because of the env and the chance.Maybe run the fail-test several times. From: Simon Horman <simon.hor...@corigine.com> Date: 2023-02-22 17:07:18 To: Faicker Mo <faicker...@ucloud.cn> Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v6] netdev-offload-tc: del ufid mapping if device not exist>On Wed, Feb 22, 2023 at 10:03:07AM +0800, Faicker Mo wrote: >> Sorry. >> The commit message and code are not changed. >> Resended when I met a bug of intel-ovs-compilation test fail and add version >> descriptions. > >Thanks, I think I understand now. >But please don't top-post on this mailing list. > >And could you please look at my comment regarding >the test you have added in this patch. > >Thanks! > >> From: Simon Horman <simon.hor...@corigine.com> >> Date: 2023-02-21 23:09:05 >> To: Faicker Mo <faicker...@ucloud.cn> >> Cc: d...@openvswitch.org >> Subject: Re: [ovs-dev] [PATCH v6] netdev-offload-tc: del ufid mapping if >> device not exist>On Wed, Feb 01, 2023 at 10:49:22AM +0800, Faicker Mo wrote: >> >> The device may be deleted and added with ifindex changed. >> >> The tc rules on the device will be deleted if the device is deleted. >> >> The func tc_del_filter will fail when flow del. The mapping of >> >> ufid to tc will not be deleted. >> >> The traffic will trigger the same flow(with same ufid) to put to tc >> >> on the new device. Duplicated ufid mapping will be added. >> >> If the hashmap is expanded, the old mapping entry will be the first entry, >> >> and now the dp flow can't be deleted. >> >> >> >> Signed-off-by: Faicker Mo <faicker...@ucloud.cn> >> >> --- >> >> v2: >> >> - Add tc offload test case >> >> v3: >> >> - No change >> >> v4: >> >> - No change >> >> v5: >> >> - No change >> >> v6: >> >> - No change >> > >> >I am confused. >> >Why are there 4 versions (v3 - v6) with no change? >> >What does that mean? > >... > >> >> diff --git a/tests/system-offloads-traffic.at >> >> b/tests/system-offloads-traffic.at >> >> index 16a4c1a00..15ea549a6 100644 >> >> --- a/tests/system-offloads-traffic.at >> >> +++ b/tests/system-offloads-traffic.at >> > >> >The test seems to pass both with and without the change to >> >del_filter_and_ufid_mapping(). I think it would be better to construct a >> >test that fails without the code change and succeeds with it. >> > >> >I ran: >> > >> >TESTSUITEFLAGS="-k ufid" make check-offloads > > >This comment, here. > >... _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
