I can run the fail-test more easier.
There exists a flow in verbose log like this,
recirc_id(0),in_port(2),eth(src=aa:1a:54:e9:c5:56,dst=86:29:2a:05:94:90),eth_type(0x0800),ipv4(frag=no),
packets:1, bytes:84, used:12.240s, actions:3
The env is strict. The hmap should be expanded exactly only once.The flow
number needs to be controlled.
By the way, should I updated the patch to v7 in here because I found it's need
to be changed when I rebased to the newest master?
From: Simon Horman <simon.hor...@corigine.com>
Date: 2023-02-23 01:12:46
To: Faicker Mo <faicker...@ucloud.cn>
Cc: d...@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v6] netdev-offload-tc: del ufid mapping if device
not exist>On Wed, Feb 22, 2023 at 04:19:37PM +0100, Simon Horman wrote:
>> On Wed, Feb 22, 2023 at 06:33:50PM +0800, Faicker Mo wrote:
>> > It's not easy to add a fail test without the changed code.
>> > But I test it failed with the old code manually following these steps,
>> > 1. Apply this patch(with test in it)
>> > 2. Revert the changed code in netdev-offload-tc.c
>> > 3. Run the test
>> >
>> >
>> > Yes, the fail-test above sometimes may pass because of the env and the
>> > chance.Maybe run the fail-test several times.
>>
>> Thanks, I see this now.
>>
>> * Without the C-code changes in this patch I saw the test fail 3 times,
>> each time within 5 attempts.
>>
>> * With the C-code change I am yet to see the test fail,
>> so far I'm up to 80 attempts.
>
>It did eventually fail on the 257th attempt.
>
>I'll try again with '-v' and see if I can capture anything useful.
>
>> I do wonder if this warrants a Fixes tag.
>> And if so, if it should be:
>>
>> Fixes: 262a07956fab ("netdev-tc-offloads: Delete ufid tc mapping in the
>> right place")
>>
>> That notwithstanding, I am happy with this patch.
>>
>> Reviewed-by: Simon Horman <simon.hor...@corigine.com>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
