On Wed, Mar 01, 2023 at 08:33:04AM +0100, Eelco Chaudron wrote:
> 
> 
> On 1 Mar 2023, at 3:12, Faicker Mo wrote:
> 
> > The device may be deleted and added with ifindex changed.
> > The tc rules on the device will be deleted if the device is deleted.
> > The func tc_del_filter will fail when flow del. The mapping of
> > ufid to tc will not be deleted.
> > The traffic will trigger the same flow(with same ufid) to put to tc
> > on the new device. Duplicated ufid mapping will be added.
> > If the hashmap is expanded, the old mapping entry will be the first entry,
> > and now the dp flow can't be deleted.
> >
> >
> > Signed-off-by: Faicker Mo <faicker...@ucloud.cn>
> 
> Change looks good to me! Did some testing and found no issues.
> 
> Acked-by: Eelco Chaudron <echau...@redhat.com>

Looks good to me too.

Reviewed-by: Simon Horman <simon.hor...@corigine.com>

I also exercised the test - both with and without the code-change.
And the code-change does significantly improve things :)

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to