On Wed, Feb 22, 2023 at 04:19:37PM +0100, Simon Horman wrote:
> On Wed, Feb 22, 2023 at 06:33:50PM +0800, Faicker Mo wrote:
> > It's not easy to add a fail test without the changed code.
> > But I test it failed with the old code manually following these steps,
> > 1. Apply this patch(with test in it)
> > 2. Revert the changed code in netdev-offload-tc.c
> > 3. Run the test
> >
> >
> > Yes, the fail-test above sometimes may pass because of the env and the
> > chance.Maybe run the fail-test several times.
>
> Thanks, I see this now.
>
> * Without the C-code changes in this patch I saw the test fail 3 times,
> each time within 5 attempts.
>
> * With the C-code change I am yet to see the test fail,
> so far I'm up to 80 attempts.
It did eventually fail on the 257th attempt.
I'll try again with '-v' and see if I can capture anything useful.
> I do wonder if this warrants a Fixes tag.
> And if so, if it should be:
>
> Fixes: 262a07956fab ("netdev-tc-offloads: Delete ufid tc mapping in the right
> place")
>
> That notwithstanding, I am happy with this patch.
>
> Reviewed-by: Simon Horman <simon.hor...@corigine.com>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
