On 21/03/16 20:59, Andy Carter wrote: > On Monday 21 Mar 2016 19:34:51 Johan Ström wrote: >> I commited a fix in a separate branch for testing. Please try: >> >> git pull >> git checkout ALL_size_fix >> (running git log now would show ac62579ecbfe7acebb2873a9a089bc5b9814cd86 >> as latest commit) >> >> Now build, and see if this works. > Almost, I now have > aaa > bbb > ccc > dddd|||||||||| > > that's 5 double pipes > > owwrite "/FF.870900000100/line20.ALL" aaa,bbb,ccc,ddd > > as before > > Log at https://gist.github.com/anonymous/0d642c671f21dd42bd78
I'm quite sure the error is at ow_parseinput.c line 462: // shorten the buffer length by the comma and discarded chars end -= entry_length - allowed_length - 1 ; The purpose is to move the endpointer, but the logic is wrong, and the last element length (line 441) is wrongly calculated base on 'end'. My currently tired brain suggests 'end -= entry_length - 1;', but I might be wrong.. And I do not have any device at all which accepts an aggregate ascii write. Do we have any unit-tests at all? Johan ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 _______________________________________________ Owfs-developers mailing list Owfs-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/owfs-developers
