https://bugzilla.redhat.com/show_bug.cgi?id=1065758
--- Comment #4 from Richard Shaw <hobbes1...@gmail.com> --- Ok, a high level review: 1. The license should be LGPLv2 (version 2.1 is the first release so the short name doesn't have the ".1") https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing 2. rpmlint output from the installed package: $ rpmlint libbatch libbatch.x86_64: W: invalid-license LGPLv2.1 libbatch.x86_64: W: invalid-url URL git.salome-platform.org/gitweb/?p=tools/libbatch.git ## This one needs to be fixed[1] ## libbatch.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/_libbatch.so _libbatch.so()(64bit) ## I can patch the cmake build to add a soname ## libbatch.x86_64: E: invalid-soname /usr/lib64/libbatch.so libbatch.so ## One thing I don't like about cmake is the way it links everything, ## adding something like "export LDFLAGS='-Wl,--as-needed'" will usually ## fix this. libbatch.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libbatch.so /lib64/libm.so.6 ## Should be reported upstream but not a blocker. libbatch.x86_64: E: incorrect-fsf-address /usr/share/doc/libbatch-2.1.0/COPYING 1 packages and 0 specfiles checked; 2 errors, 4 warnings. [1] https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Preventing_files.2Fdirectories_from_being_scanned_for_deps_.28pre-scan_filtering.29 # Do not check .so files in the python_sitelib directory # or any files in the application's directory for provides %global __provides_exclude_from ^(%{python_sitearch}/.*\\.so|%{_datadir}/myapp/.*)$ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
