On Fri, Jul 18, 2008 at 2:45 PM, Xavier <[EMAIL PROTECTED]> wrote: > On Fri, Jul 18, 2008 at 1:54 PM, Xavier <[EMAIL PROTECTED]> wrote: >> >> Anyway my proposal is to just copy/paste the good old working vercmp >> code we had, with only the above fix. >> > > So here it is. >
Apparently the static strings were a show stopper to Dan. I don't have a problem with static strings, since it removes the malloc/free overhead and also simplifies the code. As always with dynamic strings, we have the choice between duplicating all free calls, or using goto. But anyway, here is a new patch using strdup/free instead of static arrays.
0001-Revert-vercmp-code-to-the-old-version.patch
Description: application/mbox
_______________________________________________ pacman-dev mailing list [email protected] http://archlinux.org/mailman/listinfo/pacman-dev
