Yep, I just found this giving trouble in another PDL module I've released,
PDL::Fit::ExpRate. It's actually really annoying that pp_done was made a
required function call. I agree that not calling it makes it easier for
development iterations, but it will break modules that I've published on
CPAN and not touched for a long time. So now all of my PDL modules will
need to be re-released. :-/
I'll try to push a fix next week.
David
On Tue, Jun 7, 2016 at 8:34 PM, <sisyph...@optusnet.com.au> wrote:
> -----Original Message-----
> From: sisyph...@optusnet.com.au
> Sent: Tuesday, June 07, 2016 11:18 PM
> To: pdl-devel@lists.sourceforge.net
> Subject: Re: [Pdl-devel] {Win32] Problem building PDL-Drawing-Prima-0.11
>
> Problem was that line 816 of PP.pm (in the END block) has been changed to:
>
> # pp_done() unless $PDL::PP::done;
>
> Initially I fixed the problem by removing that '#" symbol, and that allowed
> successful building of PDL-Drawing-Prima-0.011 and PDL-Fit-Levmar-0.0098 -
> but I don't think that's the correct fix.
>
> The comments explaining the insertion of the '#' suggest that the 2 modules
> in question may be at fault in that *they* should be calling pp_done().
>
> And, indeed, adding a "pp_done();" at the very end of Func/func.pd fixes
> the
> problem with P-F-L-0.0098, and eliminates the need to remove the '#' from
> PP.pm.
>
> Also, adding a "pp_done();" to the end of lib/PDL/Drawing/Prima/
> Utils.pm.PL
> is sufficient to take care of the problem with P-D-P-0.11.
>
> I'll file a bug report against both of those modules tonight (when I have
> more time).
>
> Cheers,
> Rob
>
>
>
>
> ------------------------------------------------------------------------------
> What NetFlow Analyzer can do for you? Monitors network bandwidth and
> traffic
> patterns at an interface-level. Reveals which users, apps, and protocols
> are
> consuming the most bandwidth. Provides multi-vendor support for NetFlow,
> J-Flow, sFlow and other flows. Make informed decisions using capacity
> planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
> _______________________________________________
> pdl-devel mailing list
> pdl-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/pdl-devel
>
--
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." -- Brian Kernighan
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
_______________________________________________
pdl-devel mailing list
pdl-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/pdl-devel
