So, I finally got off my... well, let's just say I cut the release with
this fix included.
Thanks for helping me sort this out. Sorry it didn't hit CPAN sooner!
David
On Sun, Jun 12, 2016 at 10:28 PM, Derek Lamb <de...@boulder.swri.edu> wrote:
> Curmedgeon away!
>
> I think Inline::Pdlpp should be OK—I just now ran a quick test with only
> the pp_def and it built and ran fine. So it seems just modules were
> affected by the switch in pp_done behavior. (If Inline::Pdlpp were
> affected, then I would strongly advocate changing back to the old behavior,
> since that isn't documented anywhere.)
>
> Derek
>
>
> On Jun 12, 2016, at 1:34 PM, David Mertens <dcmertens.p...@gmail.com>
> wrote:
>
> Hey Derek,
>
> Sorry, I was just being a curmudgeon. Do you know if it's needed with
> Inline::Pdlpp, or is it automatically added? If it needs to be added, I'll
> need to update the examples in the PDL::PP chapter of the book.
>
> David
>
> On Sun, Jun 12, 2016 at 10:18 AM, Derek Lamb <de...@boulder.swri.edu>
> wrote:
>
>> The fact that pp_done() was called automatically by PP was never a
>> documented feature—in fact it was directly contradicted by the
>> documentation. Sorry to cause this headache—I didn't get any comments yea
>> or nay on the bug report or before the branch was merged into master.
>> Though probably you both didn't twig that this would be a problem (just as
>> I didn't really parse this thread until this morning—kind of a crazy week).
>>
>> Derek
>>
>> On Jun 11, 2016, at 8:24 PM, David Mertens <dcmertens.p...@gmail.com>
>> wrote:
>>
>> Yep, I just found this giving trouble in another PDL module I've
>> released, PDL::Fit::ExpRate. It's actually really annoying that pp_done was
>> made a required function call. I agree that not calling it makes it easier
>> for development iterations, but it will break modules that I've published
>> on CPAN and not touched for a long time. So now all of my PDL modules will
>> need to be re-released. :-/
>>
>> I'll try to push a fix next week.
>>
>> David
>>
>> On Tue, Jun 7, 2016 at 8:34 PM, <sisyph...@optusnet.com.au> wrote:
>>
>>> -----Original Message-----
>>> From: sisyph...@optusnet.com.au
>>> Sent: Tuesday, June 07, 2016 11:18 PM
>>> To: pdl-devel@lists.sourceforge.net
>>> Subject: Re: [Pdl-devel] {Win32] Problem building PDL-Drawing-Prima-0.11
>>>
>>> Problem was that line 816 of PP.pm (in the END block) has been changed
>>> to:
>>>
>>> # pp_done() unless $PDL::PP::done;
>>>
>>> Initially I fixed the problem by removing that '#" symbol, and that
>>> allowed
>>> successful building of PDL-Drawing-Prima-0.011 and PDL-Fit-Levmar-0.0098
>>> -
>>> but I don't think that's the correct fix.
>>>
>>> The comments explaining the insertion of the '#' suggest that the 2
>>> modules
>>> in question may be at fault in that *they* should be calling pp_done().
>>>
>>> And, indeed, adding a "pp_done();" at the very end of Func/func.pd fixes
>>> the
>>> problem with P-F-L-0.0098, and eliminates the need to remove the '#' from
>>> PP.pm.
>>>
>>> Also, adding a "pp_done();" to the end of lib/PDL/Drawing/Prima/
>>> Utils.pm.PL <http://utils.pm.pl/>
>>> is sufficient to take care of the problem with P-D-P-0.11.
>>>
>>> I'll file a bug report against both of those modules tonight (when I have
>>> more time).
>>>
>>> Cheers,
>>> Rob
>>>
>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> What NetFlow Analyzer can do for you? Monitors network bandwidth and
>>> traffic
>>> patterns at an interface-level. Reveals which users, apps, and protocols
>>> are
>>> consuming the most bandwidth. Provides multi-vendor support for NetFlow,
>>> J-Flow, sFlow and other flows. Make informed decisions using capacity
>>> planning reports.
>>> https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
>>> _______________________________________________
>>> pdl-devel mailing list
>>> pdl-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/pdl-devel
>>>
>>
>>
>>
>> --
>> "Debugging is twice as hard as writing the code in the first place.
>> Therefore, if you write the code as cleverly as possible, you are,
>> by definition, not smart enough to debug it." -- Brian Kernighan
>>
>> ------------------------------------------------------------------------------
>> What NetFlow Analyzer can do for you? Monitors network bandwidth and
>> traffic
>> patterns at an interface-level. Reveals which users, apps, and protocols
>> are
>> consuming the most bandwidth. Provides multi-vendor support for NetFlow,
>> J-Flow, sFlow and other flows. Make informed decisions using capacity
>> planning reports.
>> https://ad.doubleclick.net/ddm/clk/305295220;132659582;e_______________________________________________
>> pdl-devel mailing list
>> pdl-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/pdl-devel
>>
>>
>>
>
>
> --
> "Debugging is twice as hard as writing the code in the first place.
> Therefore, if you write the code as cleverly as possible, you are,
> by definition, not smart enough to debug it." -- Brian Kernighan
>
>
>
--
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." -- Brian Kernighan
------------------------------------------------------------------------------
_______________________________________________
pdl-devel mailing list
pdl-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/pdl-devel
