Jim Cromie wrote on Thursday, June 23, 2005 7:07 PM > Orton, Yves wrote: > > >>The problem is then that we'd also need the existing perl source > >> > >> > >normalised > > > > > >>before and after the patch, which would mean that we'd > start of with a big > >>patch to normalise the existing files. This would loose us > almost all the > >>change annotation, and current version control tools aren't > good enough to > >>show annotation ignoring whitespace changes. > >> > >> > > > >I'm wondering why cant "fix" the patches. IE, all of the > changed or added > >lines could at least have trailing whitespace removed and > leading whitespace > >appropriately changed. > > > >Yves > > > > > > > I think he meant something like: > > perl -pi.bak -e 's/^\+(.*)\s+$/$1/' patch-b4-application > > be done automatically to each patch *before* it was applied. > That would prevent things from getting worse anyway. > > I think adjustment to patchfiles are fine, as long as no > lines are added removed > (that will corrupt appication iirc)
Yes exactly what I meant. My personal concern is trailing whitespace, im not so fussed about leading whitespace, especially as my personal preference (spaces only) isn't likely to popular with others. Although IMO mixed space/tab indenting is a real PITA as not that many editors play nicely with it. Yves
