Nicholas Clark wrote:
Scrub my previous message. It was incorrect.
On Tue, Sep 06, 2005 at 11:40:12AM -0600, Jim Cromie wrote:
t/op/sprintf..............................FAILED at test 239
@@ -9101,11 +9166,9 @@
}
if (!asterisk)
- {
if( *q == '0' )
fill = *q++;
EXPECT_NUMBER(q, width);
- }
if (vectorize) {
if (vectorarg) {
You didn't want to do that. :-)
Nicholas Clark
Eww, no I didnt.
looks like I resync'd without taking a snapshot 1st, so ended up diffing
out that change.
extracting the lesson;
you either blamelogged sprintf.t to find the failing test, then found
25171 as last touch,
or you last-50'd sv.c, found the sprintf.t change,
then maybe noted the the date and touched-file overlap,
then the rogue chunk in my patch.
thanks for stepping in where my brain turned off.
now it passes all tests, threaded & unthreaded
attached diff-on-diff is smallest way to send correction.
I dont suppose Im done though :-(
Thus far, Im unable to smoke current with this patch -
Im having issues getting 'make regen' to run after the pfile is applied,
and consequently teh compile fails with stuff like:
sv.c:8451: error: `PL_body_roots' undeclared (first use in this function)
sv.c: In function `Perl_sv_dup':
sv.c:10500: error: `PL_body_roots' undeclared (first use in this function)
sv.c:10501: error: `PL_body_arenaroots' undeclared (first use in this
function)
sv.c: In function `perl_clone':
sv.c:11355: error: `PL_body_arenaroots' undeclared (first use in this
function)
sv.c:11356: error: `PL_body_roots' undeclared (first use in this function)
make: *** [sv.o] Error 1
Unable to make anything but miniperl in this configuration
Any tips welcome.
--- diff.arena-4-pub 2005-09-06 10:47:36.000000000 -0600
+++ diff.arena-4-pub-fix 2005-09-07 20:19:34.000000000 -0600
@@ -609,18 +609,6 @@
break;
}
-@@ -9101,11 +9166,9 @@
- }
-
- if (!asterisk)
-- {
- if( *q == '0' )
- fill = *q++;
- EXPECT_NUMBER(q, width);
-- }
-
- if (vectorize) {
- if (vectorarg) {
@@ -10153,7 +10216,7 @@
# define PTR_TABLE_HASH(ptr) (PTR2UV(ptr) >> 2)
#endif
