Hi hackers,

I noticed that cfbot is not entirely happy with the patch, so I rebased it.

> I see that COMPRESSION and STORAGE now are handled slightly
> differently in the grammar. Maybe we could standardize that a bit
> more; so that we have only one `STORAGE [kind]` definition in the
> grammar?
>
> As I'm new to the grammar files; would you know the difference between
> `name` and `ColId`, and why you would change from one to the other in
> ALTER COLUMN STORAGE?

Good point, Matthias. I addressed this in 0002. Does it look better now?

-- 
Best regards,
Aleksander Alekseev

Attachment: v3-0001-CREATE-TABLE-.-STORAGE.patch
Description: Binary data

Attachment: v3-0002-Handle-SET-STORAGE-and-SET-COMPRESSION-similarly.patch
Description: Binary data

Reply via email to