Hi Peter, > The "safety check: do not allow toasted storage modes unless column > datatype is TOAST-aware" could be moved into GetAttributeStorage(), so > it doesn't have to be repeated. (Note that GetAttributeCompression() > does similar checking.)
Good point. Fixed. > ATExecSetStorage() currently doesn't do any such check, and your patch > isn't adding one. Is there a reason for that? ATExecSetStorage() does this, but the check is a bit below [1]. In v7 I moved the check to GetAttributeStorage() as well. [1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/commands/tablecmds.c#l8312 -- Best regards, Aleksander Alekseev
v7-0001-Allow-specifying-STORAGE-attribute-for-a-new-tabl.patch
Description: Binary data
