On 2020-Dec-04, Michael Paquier wrote: > VacuumOption does that since 6776142, and ClusterOption since 9ebe057, > so switching ReindexOption to just match the two others still looks > like the most consistent move.
9ebe057 goes to show why this is a bad idea, since it has this: +typedef enum ClusterOption +{ + CLUOPT_RECHECK, /* recheck relation state */ + CLUOPT_VERBOSE /* print progress info */ +} ClusterOption; and then you do things like + if ($2) + n->options |= CLUOPT_VERBOSE; and then tests like + if ((options & VACOPT_VERBOSE) != 0) Now if you were to ever define third and fourth values in that enum, this would immediately start malfunctioning. FWIW I'm with Peter on this.