Tom Lane wrote: > Heikki Linnakangas <heikki.linnakan...@enterprisedb.com> writes: >> Ok, here's a patch that includes the changes to add new wal_mode GUC >> (http://archives.postgresql.org/message-id/4bd581a6.60...@enterprisedb.com), > > I haven't read this in any detail, but why does it add inclusion of > pg_control.h to xlog.h? I don't see any reason for that in the actual > changes in xlog.h.
I put the enum for wal_mode to pg_control.h, so that it's available to pg_controlinfo.c without #including xlog.h there. The XLogArchivingActive() macro in xlog.h needs the enum values: #define XLogArchivingActive() (XLogArchiveMode && wal_mode >= WAL_MODE_ARCHIVE I'm all ears for better suggestions, I didn't like that much either. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
