Heikki Linnakangas <heikki.linnakan...@enterprisedb.com> writes: > Tom Lane wrote: >> I haven't read this in any detail, but why does it add inclusion of >> pg_control.h to xlog.h? I don't see any reason for that in the actual >> changes in xlog.h.
> I put the enum for wal_mode to pg_control.h, so that it's available to > pg_controlinfo.c without #including xlog.h there. The > XLogArchivingActive() macro in xlog.h needs the enum values: Oh, I see. > I'm all ears for better suggestions, I didn't like that much either. How about putting the enum {} declaration in xlog.h, and making the field in pg_control.h just be declared "int"? I'm not sure declaring it as enum is a great idea anyway, since that makes the on-disk representation dependent on a compiler's whim as to how wide the enum will be. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers