On Wed, Dec 29, 2010 at 20:12, Alvaro Herrera <alvhe...@commandprompt.com> wrote: > Excerpts from Magnus Hagander's message of mié dic 29 11:40:34 -0300 2010: >> On Wed, Dec 29, 2010 at 15:05, Gurjeet Singh <singh.gurj...@gmail.com> wrote: > >> > Any specific reason NOREPLICATION_P and REPLICATION_P use the _P suffix? >> >> Um, I just copied it off a similar entry elsewhere. I saw no comment >> about what _P actually means, and I can't say I know. I know very >> little about the bison files :-) > > Some lexer keywords have a _P prefix because otherwise they'd collide > with some symbol in Windows header files or something like that. It's > old stuff, but I think you, Magnus, were around at that time.
Heh. That doesn't mean I *remember* it :-) But yes, I see in commit 12c942383296bd626131241c012c2ab81b081738 the comment "convert some keywords.c symbols to KEYWORD_P to prevent conflict". Based on that, I should probably change it back, right? I just tried a patch for it and it compiles and checks just fine with the _P parts removed. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
