Excerpts from Magnus Hagander's message of jue dic 30 08:57:09 -0300 2010: > On Wed, Dec 29, 2010 at 20:12, Alvaro Herrera > <alvhe...@commandprompt.com> wrote:
> > Some lexer keywords have a _P prefix because otherwise they'd collide > > with some symbol in Windows header files or something like that. It's > > old stuff, but I think you, Magnus, were around at that time. > > Heh. That doesn't mean I *remember* it :-) :-) > But yes, I see in commit 12c942383296bd626131241c012c2ab81b081738 the > comment "convert some keywords.c symbols to KEYWORD_P to prevent > conflict". Wow, what a mess of a patch ... nowadays this would be like 10 commits (or so I hope) ... hey, did Bruce sabotage the qnx4 port surreptitiously? > Based on that, I should probably change it back, right? I just tried a > patch for it and it compiles and checks just fine with the _P parts > removed. Hmm, I wouldn't bother really. It's not that important anyway, IMHO. -- Álvaro Herrera <alvhe...@commandprompt.com> The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
