On Mon, Aug 18, 2014 at 7:08 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > > On Mon, Aug 18, 2014 at 9:37 AM, Peter Eisentraut <pete...@gmx.net> wrote: > > It's not ready for committer if the current patch does not apply. > FWIW, the latest version sent by Amit here applies correctly: > http://www.postgresql.org/message-id/caa4ek1+cc9rb1s9q4+nsokfas1yufvfgfxuhxy_6wlbq1re...@mail.gmail.com > I haven't tested it myself though. > > However, independently on this patch and as pointed by MauMau, the > code that has been committed in fb05f3c is incorrect in the way it > defines the tablespace path, this: > psprintf("%s/pg_tblspc/%d", basedir, oid); > should be this: > psprintf("%s/pg_tblspc/%u", basedir, oid); > I am separating this fix (that should be backpatched to REL9_4_STABLE > as well), in the patch attached if this helps.
I think the patch provided by me needs to be back patched to 9.4 as this is a new option introduced in 9.4 which is not working on windows. With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
