This patch looks good. The only question I have is why you didn't want the pgport rename/unlink calls? We usually use them unless there is some reason not to.
--------------------------------------------------------------------------- Dave Page wrote: > > [Resent as the list seems to have rejected yesterdays attempt] > > As per Bruce's request, here's a copy of Andreas' server > instrumentation patch for review. I've separated out the > dbsize stuff and pg_terminate_backend is also not included. > > This version was generated against CVS today. > > As far as I can tell from review of comments made back to > pre-8.0, all security and other concerns raised have been addressed. > > Regards, Dave. Content-Description: instrumentation.tar.gz [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 2: you can get off all lists at once with the unregister command > (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED]) -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073 ---------------------------(end of broadcast)--------------------------- TIP 6: explain analyze is your friend
