Rewriting the function so that it had an optional parameter for line numbering (or not line numbering) would also reduce the file size of the patch. I agree this may be a better approach for highlight_file; however, .phps files use this same function... there isn't another way to set it for a phps (unless you create an ini setting).
The other option is just making it work with line numbering regardless. This won't break any scripts, just make them have line numbers instead. Devon Edin Kadribasic wrote: > On Wed, 11 Sep 2002 13:47:56 +0200 > "Devon O'Dell" <[EMAIL PROTECTED]> wrote: > > >> Hey, >> >> I don't know if this has been brought up before (you can smack me, I >> know that's the 3rd time I've said this), but something I (and others) >> >> thought would be cool is line numbering for highlight_file (aka >> show_source). >> >> I've made modifications so that this feature is settable from php.ini >> (highlight.format, either 0 or 1) and tested my source, looks like it >> works fine and the only stuff that didn't work in make test was stuff >> where the EXPECT was wrong. >> > > > Please let's not add an ini setting for every little thing. It makes > writing portable scripts very difficult. > > I think that it would be preferrable to add an optional parameter to the > exisiting function, or make a new function. > > Edin > > > -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
