On Apr 3, 2010, at 7:38 AM, Hannes Magnusson wrote:

> On Sat, Apr 3, 2010 at 05:14, Philip Olson <phi...@roshambo.org> wrote:
>> Hello everyone,
>> 
>> Please have a look at the proposed patch, which is attached to the following 
>> bug report:
>> 
>>  - http://bugs.php.net/51468
>> 
>> I'll apply it after the weekend unless something is found that needs 
>> changed. It hides most PHP 6 documentation, implements "FIXME PHP_6 ..." 
>> todo items, and uses an  entity named &removed.php.future; where appropriate.
>> 
> 
> 
>         <entry>detect_unicode</entry>
>         <entry>"1"</entry>
>         <entry>PHP_INI_ALL</entry>
> -        <entry>Available since PHP 5.1.0. Removed in PHP 6.0.0.</entry>
> +        <entry>Available since PHP 5.1.0. &removed.php.future;</entry>
> 
> Is that option deprecated today? Should it be?
> 
> -       <entry>Deprecated in PHP 5.3.0. Removed in PHP 6.0.0.</entry>
> +       <entry>&removed.php.future;</entry>
> 
> -       <entry>Available since PHP 5.0.0. Deprecated in PHP 5.3.0.
> Removed in PHP 6.0.0.</entry>
> +       <entry>Available since PHP 5.0.0. Deprecated in PHP 5.3.0.
> &removed.php.future;</entry>
> 
> Sometimes you remove the "Deprecated in " and sometimes you don't..
> 
> 
> Looks good to me

Good find, it shouldn't remove it. The original patch used the current warn. 
entity about 5.3.0/6.0.0 but inserting a <warning> everywhere seemed overkill. 
Looks like I missed a couple while revising.

Regards,
Philip

Reply via email to