Looks okay to me Shawn. Shawn Walker wrote:
UPDATED: The following webrev includes proposed fixes for the following bugs:244 Filter parser throws exception on numeric filters or filter values webrev: http://cr.opensolaris.org/~swalker/pkg-244/ hg bundle: http://cr.opensolaris.org/~swalker/pkg-244/raw_files/pkg-244.hg hg export: http://cr.opensolaris.org/~swalker/pkg-244/raw_files/pkg-244.patch Yes, I ran pylint :-) UPDATES FOR TAKE 2: I have added a significant number of tests, gotten rid of some redundant ones, and in general greatly enhanced filter parsing. You can now have filters such as these (the following would fail previously): 386=true version=9 version=0.6.5.4.3.2.1 version=0.6a.5b.4c.3d.2e.1f 0.i3.8.6=cpuarch version=0.9 & (0.i.3.8.6=cpuarch | 0.9.9=foobar) | version=0.a6.b5.c4.d3.e2.f1 Contributor #OS0004 Cheers,
smime.p7s
Description: S/MIME Cryptographic Signature
_______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
