On Wed, Mar 12, 2008 at 11:13:21PM -0500, Shawn Walker wrote:
> http://cr.opensolaris.org/~swalker/pkg-244/
filter.py:
- I'm a bit confused by want_attr and want_value: are they ever anything
other than opposites? You always seem to set them in concert.
- line 57,59: could NAME ever follow NAME or NUMBER follow NUMBER in a
token stream? It seems like that would represent a broken filter if it
could.
- line 62: should we assert "not want_attr"?
- line 64-66: presumably there won't be anything further after this
token, right? So do you need these lines?
- line 70: extra comma
- line 79: need space after comma.
- line 82: maybe it's just me, but you might want to put a comment before
this to explain why the tokens you're testing for before this are
different from the tokens you're testing after. I think it might also
be the case that want_value is always True here (and want_attr is
False), so you might be able to do without the if entirely. But I'd
still comment on the split you've made here.
I'm assuming that the bulk of your changes in t_filter.py are tabs to
spaces, plus the addition of the extra test cases, so I'm going to assume
that's all correct. :)
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
