On Fri, Mar 14, 2008 at 3:10 PM, Danek Duvall <[EMAIL PROTECTED]> wrote: > Okay. You've ended up with a lot more comments than I would have done, but > if you find them useful, I won't complain. But you have typos on lines 55 > and 103 which you should correct.
Argh. I'll fix those. > I'd also generally appreciate it if you didn't overwrite old webrevs, as > it's often nice to take a look at my comments in the context of the thing I > was reviewing, rather than trying to figure out what I might have been > talking about. I'm guilty of this, too, and it doesn't always matter, but > this was one case where I wanted to look at the previous revision. Sorry about that. I'll try to keep that in mind for the future. I'll probably just link them as: pkg-244 (original) pkg-244-2 pkg-244-3 ...etc. Hopefully it won't ever go beyond -3 :) > Code looks fine. Great. Once I fix the two typos, I'll commit it later tonight. Again, your review was appreciated. Cheers, -- Shawn Walker, Software and Systems Analyst http://binarycrusader.blogspot.com/ "To err is human -- and to blame it on a computer is even more so." - Robert Orben _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
