Okay. You've ended up with a lot more comments than I would have done, but if you find them useful, I won't complain. But you have typos on lines 55 and 103 which you should correct.
I'd also generally appreciate it if you didn't overwrite old webrevs, as it's often nice to take a look at my comments in the context of the thing I was reviewing, rather than trying to figure out what I might have been talking about. I'm guilty of this, too, and it doesn't always matter, but this was one case where I wanted to look at the previous revision. Code looks fine. Thanks, Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
