> Webrev:
> http://cr.opensolaris.org/~tmueller/cr-2402,2415/
The changes that you've made to filelist break existing functionality
for retries. These changes will also make it more difficult for me to
retry failed requests against different mirrors.
-1
filelist.py:
- line 111-113: You've taken out a check that we use to incrementally
download files as we fill up a filelist. The while is here in case
we don't successfully download all of the files in the first try.
- line 129 & 130: Why are you making the filelist hold an arbitrarily
large number of files? Dan did a bunch of work to tune the size of
a filelist to optimize its retrieval time. It seems like you're
un-doing most of that work.
- line 283-285: Why are we deferring the work when we can do it
earlier? It seems like we're making this needlessly complex by
stuffing this functionality into _get_files. This is also going to
bloat the size of a filelist object. We've specifically spent time
trying to optimize our memory footprint. This seems ripe for
regression.
- line 335-343: Why did you remove this check?
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
