I posted an updated webrev based on the current gate.

http://cr.opensolaris.org/~tmueller/cr-2402,2415-2/

The code really didn't need to change except for the line numbers where lines are inserted.

Tom

Danek Duvall wrote:
On Tue, Jul 15, 2008 at 04:22:47PM -0500, Tom Mueller (pkg-discuss) wrote:

http://cr.opensolaris.org/~tmueller/cr-2402,2415/

There's a bunch of stuff here (filelist mods, mostly) that looks like you
needed to merge with the gate properly.

Seems like there's a window between preinstall and the time the file is
actually renamed onto where a process could open that file, wasting your
original check.  And even if the check fails at the time of download, that
doesn't mean it would fail at install time.

Danek

begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;Update Center Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[EMAIL PROTECTED]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to