Krister and Danek had raised some concerns with a previous attempt at
fixing these issues. So here is a new fix that hopefully addresses
those concerns.
Issues:
http://defect.opensolaris.org/bz/show_bug.cgi?id=2402
http://defect.opensolaris.org/bz/show_bug.cgi?id=2415
Webrev:
http://cr.opensolaris.org/~tmueller/cr-2402,2415-3/
The change from the previous version of this is that this fix does not
modify the filelist module at all. Rather, it moves the code in pkgplan
that creates and manipulates the filelist to the PkgPlan.download method
rather than the PkgPlan.preexecute method.
Also, the code that removes the "installed" file during an uninstall is
moved to the PkgPlan.postexecute method rather than preexecute. This is
the same place where the "installed" file is removed for a package that
is updated. This allows the action preinstall or preremove methods to
abort the plan by throwing an exception, without having the image
modified before that happens. Also, if the download is aborted, no
installed files will have been removed.
All of the changes since the last review are in the pkgplan.py file (and
there are no changes to filelist.py anymore).
Thanks.
Tom
begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;Update Center Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[EMAIL PROTECTED]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
