Tom,

>> filelist.py:
>>
>>   - line 111-113: You've taken out a check that we use to incrementally
>>     download files as we fill up a filelist.  The while is here in case
>>     we don't successfully download all of the files in the first try.
>>   
> Yes, this is intentional.  In fact, I was surprised that filelist started 
> downloading files before all of the actions had been processed, as this 
> misses the opportunity to download files with the same hashval only once 
> (unless they happen to be close to each other in the manifest).

We keep the downloaded files in a content cache now.  If we've
downloaded a file once during a transaction, we're not going to download
it again.  Generating a huge number of filelist objects and then issuing
the download in a separate pass is both unnecessary and likely to bloat
our memory footprint.

-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to