On Tue, Aug 19, 2008 at 02:07:18PM -0700, [EMAIL PROTECTED] wrote: > http://cr.opensolaris.org/~johansen/webrev-2951/
I think you need more safety checks in build_cert(). I'd put the file() and read() in a try block rather than doing the exists check, which should check for more problems than simple non-existence. Also, What happens if the file is readable, but not a proper PEM file? Does load_certificate() raise any exceptions if certdata is garbage, or does it just return None silently? Line 1529: why is this here? Line 1651: too computery a message. Perhaps say that the certificate isn't valid/effective until nbdt (or perhaps whatever the local time equivalent is)? I'm also a bit concerned that we're piling this directly into client.py, rather than extracting it out into separate code that the gui could reuse. As it is, this will just lead to more code copying. Fixing that would require more insight into how the cert-handling code will evolve than I have, so I'm not sure how to guide you on that. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
