* Danek Duvall <[EMAIL PROTECTED]> [2008-08-20 17:53]: > On Tue, Aug 19, 2008 at 02:07:18PM -0700, [EMAIL PROTECTED] wrote: > > > http://cr.opensolaris.org/~johansen/webrev-2951/ > > Line 1651: too computery a message. Perhaps say that the certificate isn't > valid/effective until nbdt (or perhaps whatever the local time equivalent is)? "Certification for authority %s not yet valid", maybe?
You might even consider writing both messages such that the relevant datetime is displayed. > I'm also a bit concerned that we're piling this directly into client.py, > rather than extracting it out into separate code that the gui could reuse. > As it is, this will just lead to more code copying. Fixing that would > require more insight into how the cert-handling code will evolve than I > have, so I'm not sure how to guide you on that. Agree. I suggest pkg.misc as a better home than client.py, until we straighten out where different policies might go... Instead of spreading out the if blocks for certificate checks into each command, I wonder if we should group the "switch" at 1730 into operations that contact authorities and those that don't, and only check for the former? (There's a similar grouping about modifying and non-modifying operations and privilege checking, so I'm just wondering about the subcommand factoring we have...) - Stephen -- [EMAIL PROTECTED] http://blogs.sun.com/sch/ _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
