[EMAIL PROTECTED] wrote: > Danek, the clever guy that he is, found a bug in our handling of some > download caching issues. This problem occurs when you have old content > from a previous build, and then download manifests that have a hash on > the compressed content. In certain situations, the cached content's > hash won't match that in the manifest. This isn't fatal, but we were > treating it as such. In this situation, we actually want to remove the > item from the cache and download a new piece of content. > > This webrev fixes the issue: > > http://cr.opensolaris.org/~johansen/webrev-3099/ > > Thanks, > > -j > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > LGTM. Just so that I'm clear on how this works...
Before, if the file was in the cache, we'd check it, note that it didn't verify (which deletes it) and return to the user. Now, if it's in the cache we do the same thing, but catch the exception. We actually go over the network because we fall out of the except block which eventually takes us into _add_action which adds us to self.fhash which is the list/dict that's iterated over to decide what to actually go across the network to download. Have I got it straight? Thanks, Brock _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
