On Tue, Aug 26, 2008 at 05:44:24PM -0700, [EMAIL PROTECTED] wrote: > http://cr.opensolaris.org/~johansen/webrev-3099/
This looks fine to me, though I would drop the extraneous ", e" from the except line, and capitalize "None" in the comment. By catching this here, can an InvalidContentException propagate outside of this module anymore? That is, is the code in client.py to catch it dead now, or are there other paths to get there? I see that you could get it from _extract_files(), but I'm not sure what all the paths to that are. At any rate, that's something that should be put off for another wad, as fixing it is probably too risky for this late hour. Thanks, Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
