> > http://cr.opensolaris.org/~johansen/webrev-3099/ > > This looks fine to me, though I would drop the extraneous ", e" from the > except line, and capitalize "None" in the comment.
Ok, I'll do both. > By catching this here, can an InvalidContentException propagate outside of > this module anymore? That is, is the code in client.py to catch it dead > now, or are there other paths to get there? I see that you could get it > from _extract_files(), but I'm not sure what all the paths to that are. An InvalidContentException can still get out to main() through the _extract_files() -> _get_files() -> do_get_files() path. I was under the impression that we still wanted to see those exceptions. Am I misinformed? Thanks, -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
