On Tue, Sep 02, 2008 at 03:01:09PM -0500, Shawn Walker wrote: > Danek Duvall wrote: >> http://cr.opensolaris.org/~dduvall/pkg-devlinks/ >> >> This fixes >> >> 2349 import of 86 fails on kernel/drv/sd.conf >> 2839 driver actions should support devlinks > > driver.py: > lines 158-159, 263-264, 660-661: Should this be a __ attribute on self > that is generated once or a static helper method somewhere else?
I'm not sure this is worthwhile. You can't generate it once, since actions aren't created with an image you can rely on, and indeed, the image is only passed in at install or uninstall time. So a static method would work, but after looking at the implementation it's not clear that there's much benefit. However, one that takes an image and the base path might be -- and will be usable for name_to_major and the rest. Dan and David, this is a ping for the two of you to review this, make sure it's sane. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
