On Thu, Oct 02, 2008 at 03:53:53PM -0700, Dan Price wrote: > When you add the devlink entry, I notice that there is checking for > dups, and no dups are added. When the package is removed, that will > presumably nuke the devlinks and when the second package is removed, > we'll emit the warning you added. I was wondering if it might make > sense to actually stick the dup entries into the file and in the remove > logic, take care to only remove one instance of the entry. That would > effectively do the reference counting you'd want, and presumably > wouldn't hurt. You'd have to see if the kernel tolerates it.
How would I test that substantially? Could the behavior be driver dependent? > When writing to devlink.tab, it'd be nice to write a new devlink.tab > file and then move it into place. If you run into ENOSPC here, the > system will be fubar. Good idea. > What happens to this code in the unlikely case that devlink.tab does > not exist? Looks like there's one instance where I forgot to put a read of the file inside a try/catch, so I'll fix that up. In all other cases (and if we get any other errors during install or removal), we print a message and bail out. > Saying that things "were found missing" is awkward. Use "were missing" > or "were not found". I used "... were not found", since "were missing" leaves us with an orphan. Thanks, Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
