Shawn Walker wrote: > Greetings, > > The following webrev contains changes necessary to implement these > (known) bug entries: > > 1449 pkg requires operational history
Based on the feedback here, I've almost completely rewritten my operational history changes. The concepts are the same, but the implementation only bears a passing resemblance to the prior one. I've filed a few bugs for things I plan to defer until later as this changeset is already quite large: 3304 operational history retention policy desired 3418 operational history error logging desired 3419 history command -- ability to specify dates or date ranges desired 3420 purge-history command -- control over what is purged desired There is no diff from the last webrev as it would be pointless given the amount of changes. webrev: http://cr.opensolaris.org/~swalker/pkg-1449-2/ Updated sample history output: Short format: http://cr.opensolaris.org/~swalker/pkg-1449-2/short.txt Long format: http://cr.opensolaris.org/~swalker/pkg-1449-2/long.txt Sample purge history output: http://cr.opensolaris.org/~swalker/pkg-1449-2/purge.txt Change Summary (from last webrev) ============== * Rewrote history module as History class. * Added history property to image object which is where the instance of the history object is now stored. * Changed history to allow a stack of operations to prevent data loss. * Changed return_code to result which is now a list containing result, reason (e.g. ["Succeeded"], ["Failed", "Constrained"]) * Changed function-based interface to an attribute-based one. * Deferred recording of errors (for now) to bug 3418. * Added purge-history command to accommodate installation team and as a stop-gap until 3420 is implemented. * Changed short output format to show "Time", "Operation", "Client", "Outcome" instead of the not as useful "TIME", "COMMAND" format. Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
