On Fri, Sep 19, 2008 at 06:22:27PM -0500, Shawn Walker wrote: >> client.py: >> - 1424: why the wrap? Ditto for 1641, and a handful of other places >> where the lines were exactly at 80 chars. > > Because PEP8 says 79 characters for wrap, not 80?
Grr. I'd rather use the ON standard of 80. Most of the point is readability, and line wrapping because of a single character often makes the code less readable, thus defeating the whole point. Which is why I often just leave a line at 81 characters, too. The tools don't like it, but for now I'd rather tell the tools to go stuff themselves. > Yeah, we don't really differentiate right now between just setting > attributes and creating an image. I've updated this to check for the > existence of cfg_cache and assume that if it doesn't exist, then it's an > image-create; otherwise it's an image-set-attributes. It's not a perfect > solution, but it should catch most cases. > > How does that strike you? Sure, works fine. It may change after Tom's wad comes in, anyway. >> - I'm not sure that AttributeError is the right exception to use. Might >> want to have your own here. Don't care too much. > > It was the example given in the python documentation. Eh, okay. I've been finding over time as we get more serious in our implementation that having specific exceptions is an improvement. Let the built-in exceptions be used for the low-level stuff, and distinguish those from our own infrastructure. But like I said, I don't care too much for this. We can always change it later. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
