Shawn Walker wrote: > Shawn Walker wrote: >> Greetings, >> >> The following webrev contains changes necessary to implement these >> (known) bug entries: >> >> 1449 pkg requires operational history > ... > webrev: > http://cr.opensolaris.org/~swalker/pkg-1449-2/
I realised yesterday that I had missed a few changes from previous review comments and I had forgotten to add two tests. These changes of course uncovered a bug in the multiple-operations-in-a-second file handling code. Updated webrev: http://cr.opensolaris.org/~swalker/pkg-1449-3/ Diff from last webrev: http://cr.opensolaris.org/~swalker/pkg-1449-3/v2-v3.patch Change Summary ============== - Added doc/history.txt describing history and it's file format. - Added additional hooks for operation results due to merging with pkg tip (fmri changes). - Removed an errant comment in modules/client/history.py - Fixed file writing logic to properly generate sequence in modules/client/history.py - Corrected comment in History._save - Fixed line wrapping in modules/client/image.py for a change I made - Added a "stacked operations" test to api/t_history to verify that multiple, stacked operations are possible and are saved correctly - Updated tests/baseline.txt - Added a purge-history test to cli/t_pkg_history to verify that the new purge-history command works as expected Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
