On Tue, Sep 16, 2008 at 06:24:08PM -0500, Shawn Walker wrote:
> Shawn Walker wrote:
> > Shawn Walker wrote:
> >> Greetings,
> >>
> >> The following webrev contains changes necessary to implement these
> >> (known) bug entries:
> >>
> >> 1449 pkg requires operational history
> >
> ...
> > webrev:
> > http://cr.opensolaris.org/~swalker/pkg-1449-2/
>
> I realised yesterday that I had missed a few changes from previous
> review comments and I had forgotten to add two tests. These changes of
> course uncovered a bug in the multiple-operations-in-a-second file
> handling code.
>
> Updated webrev:
> http://cr.opensolaris.org/~swalker/pkg-1449-3/
Hey Shawn,
Sorry for being late to review..
So I think it looks good for the most part. The only real comment I have is
that I liked the start/end methods you had before compared to the attribute
based model. Seeing something like:
480 + img.history.operation_name = "image-update"
makes me think it's just setting the name, but it's actually starting a new
history operation, etc. Just seems clearer to have explicit start/end methods
to me.
Thanks,
Brad
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
