Line 892, 1039, 1044: Indentation doesn't seem right 1052: this line is hard to read as is, not sure what the correct handling of it is though, I'll let someone else who's better informed on the details speak to it
1032-1034, 1055-1057, 1062-1067, 1071-1072, 1075-1077, 1092-1093, 1097, 1268-1270: I believe the indentation on these lines is not correct, but I'd like Shawn or Danek (or someone else who feels strongly about it) to take a look. At the very least, the indentation of these lines and the next batch needs to be consistent. 1215-1217, 1245-1247, 1447-1450: This indentation doesn't agree with the lines above. I tend to think this is actually the correct approach, but I'll let someone who's more knowledgeable say for certain. 1434-1436, 1460, 1479: this should be intended 4 spaces, not however many they currently are Brock Padraig O'Briain wrote: > I have updated the webrev > http://cr.opensolaris.org/~padraig/ips-5175-v2/ to address Brock's > comments. > > Padraig > > On 12/04/08 20:14, Brock Pytlik wrote: >> Lines 147, 158-162, 178, 194, 261, 399-406, 409-413, 416-420, 423-427, >> 430-434, 437-441, 445, 448, 454, 459, 466, 611-614, 643, 725, 726, and >> more should not have \'s because they're inside parens. Since this is a >> formatting fix, it makes sense to fix these issues as well. >> >> Brock >> >> >> jmr wrote: >> >>> Simple formatting change. Looks fine. >>> >>> JR >>> >>> >>> >>> The webrev is at http://cr.opensolaris.org/~padraig/ips-5175-1/. >>> <http://cr.opensolaris.org/%7Epadraig/ips-5175-1/> >>> >>> This is a fix for http://defect.opensolaris.org/bz/show_bug.cgi?id=5175 >>> Wrong spacing in the updatemanager.py >>> >>> The only changes are to indentation. >>> >>> Padraig >>> >>> _______________________________________________ >>> pkg-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >>> >>> >> >> _______________________________________________ >> pkg-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >> > ------------------------------------------------------------------------ > > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
