Michal Pryc wrote: > Danek Duvall wrote: > >> On Mon, Dec 08, 2008 at 10:50:18AM +0000, Padraig O'Briain wrote: >> >> >>> http://cr.opensolaris.org/~padraig/ips-5175-v5/ >>> >> Why does a fix for a whitespace bug include changing the API version? >> > I've logged a bug > http://defect.opensolaris.org/bz/show_bug.cgi?id=5715 > > There are dual purposes to the API version. The primary one is to allow the API to verify the client is someone it can talk to. The secondary benefit is that for the client, it tracks what optional changes it's integrated and which it hasn't, to some extent at least. I'm not claiming it's a perfect mechanism, suppose you want to take the addition in version 6, but not 5 or 4, there's no way for a single number to capture that. Before you bump the version for no reason, please check to be sure that either the changes made in 5 and 6 are ones you don't care about or that you've already made changes to make use of them.
Brock >> Line >> 910 also looks like an unrelated fix. >> > It is not related, but I don't think logging a bug for every line change > is necessary?? Anyway I've logged: > http://defect.opensolaris.org/bz/show_bug.cgi?id=5716 > > >> Extraneous slashes on: 147, 398, 410 >> > > There were few more of those so I did search for all "\" and removed the > ones between "()". > > >> Line 1040: "OpenSolaris". >> > Changed, I will not log a bug against this... even if this is not > related to 5175. > > Also there was one problem shown by pylint, which is fixed: > 1361 - bad indentation. > > I am making this webrev on behalf of Padraig as he is not working Today > and I really want to start landing the changes. > > New webrev: > http://cr.opensolaris.org/~migi/09_12_2008_bugs5175_5715_5716/ > > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
