Danek Duvall wrote: > On Mon, Dec 08, 2008 at 10:50:18AM +0000, Padraig O'Briain wrote: > >> http://cr.opensolaris.org/~padraig/ips-5175-v5/ > > Why does a fix for a whitespace bug include changing the API version? I've logged a bug http://defect.opensolaris.org/bz/show_bug.cgi?id=5715
> Line > 910 also looks like an unrelated fix. It is not related, but I don't think logging a bug for every line change is necessary?? Anyway I've logged: http://defect.opensolaris.org/bz/show_bug.cgi?id=5716 > Extraneous slashes on: 147, 398, 410 There were few more of those so I did search for all "\" and removed the ones between "()". > Line 1040: "OpenSolaris". Changed, I will not log a bug against this... even if this is not related to 5175. Also there was one problem shown by pylint, which is fixed: 1361 - bad indentation. I am making this webrev on behalf of Padraig as he is not working Today and I really want to start landing the changes. New webrev: http://cr.opensolaris.org/~migi/09_12_2008_bugs5175_5715_5716/ -- best Michal Pryc _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
