Updated webrev to
http://cr.opensolaris.org/~padraig/ips-5175-v5/
as previous one did not apply to HEAD.
Padraig
On 12/08/08 10:04, Padraig O'Briain wrote:
I think I have addressed these issues..
Webrev is at http://cr.opensolaris.org/~padraig/ips-5175-v4/
Padraig
On 12/08/08 09:16, Shawn Walker wrote:
Padraig O'Briain wrote:
I have updated the webrev
http://cr.opensolaris.org/~padraig/ips-5175-v3/ .
I think I have all the indentations consistent now.
Yes, this looks greatly improved.
Only a few minor things left:
updatemanager.py:
lines 820-822: can you use misc.bytes_to_str here instead for
consistency?
lines 1217, 1247: s/exceded/exceeded/
lines 1217, 1247, 1269, 1272, 1273 (other places?): s/disc/disk/
Cheers,
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
