Bart Smaalders wrote: > http://cr.opensolaris.org/~barts/FatPkgs/ > 3245 need to support creation of multi-architecture (fat) packages > 5862 gen_actions_by_type isn't filtered, caching breaks filter changes > > Note that some support is there for facets, but the primary focus is > on variants. There will be more coming, but this is needed so that > we can merge sparc and x86 repos.
Can you update the copyright year in the files you changed? doc/facets.txt: line 6: s/naming such components,/naming such components;/ line 7: s/-devel -doc/-devel, -doc/ line 20: s/etc/etc./ line 27: What is the standard we'll be using for locale naming conventions? I assume whatever one OpenSolaris follows for its own localisation use? line 42: s/ANDED/ANDed/ line 36: s/. A/. A/ line 43: Should this be s/facet/facet or variant/ ? line 45: s/matches/matches,/ ? lines 45-47: Is this saying that if facet.devel=false is set on the action, but not set in the image, the action will be deselected; or only when fact.devel=true? line 54: s/. This/. This/ line 57: s/. It/. It/ line 59: s/ that// line 69: Should this be facet.*=true or facet.*=false as opposed to facet.*=*? If not, what does facet.*=* mean? line 101: s/s\/he/they/ doc/scripting.txt: line 3: s/SVr4/SVR4/ ? line 4: s/in/in various/ line 5: s/context, which may include/contexts, which may include: / line 6: s/OS versions,/OS versions;/ line 47: s/svr4/SVR4/ ? line 84: s/SVr4/SVR4/ ? line 88: s/receving/receiving/ line 88: s/action/actions/ line 105: s/etc/etc./ line 107: s/etc/etc.,/ line 114: extra newline? line 116: s/SVr4/SVR4/ ? lines 123-130: extra newlines? src/client.py: line 108: variant needs to be added to usage() line 1876: I think we want to reserve -v for verbose for consistency with other subcommands; using -v for --variant seems problematic. Also, if they're providing --variant, they've already told us what follows are variant related, so why force them to say variant.arch=sparc, instead of just saying arch=sparc? line 1884: s/'<name>=<value>; variant.arch=sparc for example'/'variant.<name>=<value>' (e.g. variant.arch=sparc)/ ? client/api_errors.py: line 118: s/=/ = / client/image.py: line 285: drop? line 292: insert newline here? line 295-296: is this reversed? doesn't seem to match logic at lines 349-350. line 335: s/ = /=/g line 1338: s/simple/XXX simple/ ? line 1346: extra newline? client/pkgplan.py: line 154-155: commented lines? client/variant.py: Is this module really client specific? Doesn't it belong under modules/ instead? I would like to have the web interface present the effect of variants on a package. Class comments / function comments would be nice. lines 77-81: extra newlines? modules/manifest.py: lines 98-99: s/ #/ #/ line 172: s/manifests/manifest's/ ? line 178: extra newline? lines 179-184: odd indentation here line 187: drop? line 188: extra newline? line 196: s/#determine/# determine/ lines 203-215: wow; now that's a list comprehension lines 247, 257: s/;// lines 281-283: indentation seems odd, also seems that this could be on a single-line... cli/testutils.py: line 287: s/ = /=/ Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
