Brock Pytlik wrote: > Other than my general confusion involving whether filters are still > around or not, things looks good. What's below are mostly nits. >
Filters are barely there; they barely worked before as well. This still needs help, but I'd like to focus on variants and facets first. I think the general approach will work for filters as well... > api_errors.py: > 109-110: I'd be happier with the default values being none, even with > the warning there. Maybe a small internal function could be defined that > transformed None into the [] and otherwise passed the value through, and > apply that function to each argument where it's assigned to the instance > variable. > ok. > image.py: > 349: can this line be removed, or is it still used elsewhere? I'll admit > I'm not clear on the exact interaction between filters, facets, and > variants. Is the first totally replaced by the later two? If so, do we > have any way of transforming existing filters into facets+variants so > that users don't have to redo their settings? > Old images are handled automatically already; the appropriate variants are added. I can also remove the filter spec if desired. > pkgplan.py: > 118: can filters be removed from here? > 154-155: remove the commented lines, or are we preserving them on purpose? > Yes; when reworked filters will be part of excludes mechanism. I'll remove this for now. > merge.py: > 55: should [-v varname ...] be [-v varname,url ...]? > yup... - Bart -- Bart Smaalders Solaris Kernel Performance [email protected] http://blogs.sun.com/barts "You will contribute more with mercurial than with thunderbird." _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
